Update spotless to meet JDK-21 baseline#533
Merged
prudhvigodithi merged 1 commit intoopensearch-project:mainfrom Feb 9, 2024
Merged
Update spotless to meet JDK-21 baseline#533prudhvigodithi merged 1 commit intoopensearch-project:mainfrom
prudhvigodithi merged 1 commit intoopensearch-project:mainfrom
Conversation
Contributor
Author
|
@ansjcy purely formatting updates (spotless update is needed to work with JDK-21) |
reta
commented
Feb 6, 2024
| @@ -34,6 +35,7 @@ | |||
| @PowerMockIgnore({"org.apache.logging.log4j.*", "com.sun.org.apache.xerces.*"}) | |||
| @RunWith(PowerMockRunner.class) | |||
| @PrepareForTest({NetClient.class, InterNodeRpcServiceGrpc.InterNodeRpcServiceStub.class}) | |||
| @Ignore("See please https://github.com/opensearch-project/performance-analyzer-rca/issues/529") | |||
Contributor
Author
95 tasks
getsaurabh02
previously approved these changes
Feb 6, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #533 +/- ##
=========================================
Coverage 74.41% 74.42%
Complexity 2666 2666
=========================================
Files 317 317
Lines 16377 16377
Branches 1282 1282
=========================================
+ Hits 12187 12188 +1
+ Misses 3675 3674 -1
Partials 515 515 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Andriy Redko <andriy.redko@aiven.io>
reta
changed the title
Member
|
Looks like this is the change required for 2.12 builds to pass, opensearch-project/performance-analyzer#611, can we please get this in soon and backport to 2.x? |
bbarani
approved these changes
Feb 9, 2024
88 tasks
prudhvigodithi
approved these changes
Feb 9, 2024
|
The backport to To backport manually, run these commands in your terminal: # Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-2.x 2.x
# Navigate to the new working tree
cd .worktrees/backport-2.x
# Create a new branch
git switch --create backport/backport-533-to-2.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 3c92f12e3ef0789bc7c7bda2a28b85a350008e80
# Push it to GitHub
git push --set-upstream origin backport/backport-533-to-2.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-2.xThen, create a pull request where the |
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Is your feature request related to a problem? Please provide an existing Issue # , or describe.
Add JDK-21 to Github actions
Describe the solution you are proposing
A clear and concise description of what you want to happen.
Describe alternatives you've considered
A clear and concise description of any alternative solutions or features you've considered.
Additional context
Add any other context or screenshots about the feature request here.
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.